Add widget context as an argument to the jQuery script #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@diego-antonelli are you ok with me merging this change and releasing a new version? |
Contributor
|
@JelteMX this widget is now responsibility of Web Content and PMs.. We should ask them first. |
Contributor
|
@cjfhodges can you check it? |
|
@JelteMX was this a reported bug? |
Contributor
Author
|
@cjfhodges this was a bug we encountered in one of our internal projects (OKR) after they updated to a new version of the widget. My changes will make it work again (and a test-version with these changes runs successfully in the project). I will merge and release a new version |
diego-antonelli
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For certain scripts we need to include the widget itself as a context. In versions before 3.9.3 this worked, as
thisrefered to the widget itself. In that version the context was changed to an object with only jQuery as a context.This fix will add the widget itself as a context as well, so we can do: